Martin Mucha has posted comments on this change. Change subject: webadmin: removed caching from EnumTranslator. ......................................................................
Patch Set 4: Ah, I finally picked up how that commenting stuff works. So. There was few comments for you in code, but for some reason it was not published and gerrit refuses to publish them now, probably since they're related to former patch set. So I stubbornly place them here, giving response to your comments. change set 1: Alona Kaplan Mar 25 7:35 AM You can remove the inheritance from translator and make this method static. So you won't need to create any instances of EnumTranslator. --> no static methods, I fixed it using singleton pattern. change set2: I did remove all unrelevant changes, I DIDN'T inline variables Alona Kaplan Apr 1 8:53 AM Please use EnumTranslator.getInstance() directrly. No need for a variable. --> I really do not want to do that; in many cases it just makes code less readable and/or line too long. One more variable is not any problem and if it makes code more readable (it does) and effitient (it does) it's benefitial to have that one more line there. Alona Kaplan Apr 1 8:53 AM Why did you move the method? [explanation: method was moved from class to anonymous inner class] --> I did that, because that method was unused from elsewhere, thus it belongs into that anonymous inner class instead of enclosing class. --- requested change of renaming 'get' method to 'translate' will be done in 'change Translator to interface' since this patch set deals only with caching removal, while that another one changes API of Translator and its class hierarchy so the change belongs there better. -- To view, visit http://gerrit.ovirt.org/26048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3df424d8e7a35ed249b2760da79deba7db31b785 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
