Michael Kublin has submitted this change and it was merged. Change subject: core : Last patch for removing internal_drive_mappings ......................................................................
core : Last patch for removing internal_drive_mappings The following patch is removing a usage of internal_drive_mappings at the ovirt. There were couple of commands which were based on internal_drive_mapping, but actually not in use any more. The following commands, queries were removed Change-Id: I11e51e457124ba1e5ea33ffe81b8ea32758530f7 Signed-off-by: Michael Kublin <mkub...@redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromImportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImagesFromImportCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddTemplateImagesFromImportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromImportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllImportCandidatesInfoQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByDriveQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCandidateInfoQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImportCandidatesBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImportCandidatesInfoQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImportCandidatesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByDriveQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromImportParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImagesFromImportParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVMFromImportCandidateParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromImportParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImagesComparerByName.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CandidateInfoParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllImportCandidatesQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByDriveParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImportCandidatesQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetCandidateInfoVDSCommandParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImportCandidatesVDSCommandParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ImportCandidateVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDriveMappingComparator.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetCandidateInfoVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidateBase.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidatesInfoVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidatesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportCandidateInfoReturnForXmlRpc.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportCandidateVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportCandidatesInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsVMListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateDiskListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/SnapshotsTree.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/DataProvider.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/Linq.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserVmModel.java D frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/GetAllVmSnapshotsExecutor.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmImportDiskListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/GetAllVmSnapshotsExecutor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/DiskImageWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 92 files changed, 87 insertions(+), 2,312 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11e51e457124ba1e5ea33ffe81b8ea32758530f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
