Michal Skrivanek has posted comments on this change. Change subject: Added support for polkit and sudo ......................................................................
Patch Set 9: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/26663/9/Makefile.am File Makefile.am: Line 4: ovirt-guest-agent \ Line 5: GinaSSO \ Line 6: tests \ Line 7: windows-credprov \ Line 8: scripts \ ws Line 9: $(NULL) Line 10: Line 11: if BUILD_SSO_MODULES Line 12: SUBDIRS += \ http://gerrit.ovirt.org/#/c/26663/9/scripts/Makefile.am File scripts/Makefile.am: Line 1: SUBDIRS = \ Line 2: wrappers \ indentation in the whole file? Line 3: $(NULL) Line 4: Line 5: EXTRA_DIST= \ Line 6: sudoers.ovirt-guest-agent \ http://gerrit.ovirt.org/#/c/26663/9/scripts/sudoers.ovirt-guest-agent File scripts/sudoers.ovirt-guest-agent: Line 2: /usr/share/ovirt-guest-agent/ovirt-hibernate-wrapper.sh *,\ Line 3: /usr/share/ovirt-guest-agent/ovirt-shutdown-wrappers.h *,\ Line 4: /usr/share/ovirt-guest-agent/ovirt-locksession-wrapper.sh Line 5: Line 6: ovirtagent ALL=(ALL) NOPASSWD: OVIRTAGENT_SCRIPTS why (ALL)? Line 7: Defaults:ovirtagent !requiretty http://gerrit.ovirt.org/#/c/26663/9/scripts/wrappers/ovirt-sudo-wrapper.sh File scripts/wrappers/ovirt-sudo-wrapper.sh: Line 1: #! /bin/bash I'd prefer "#!/bin/bash". Alon would certainly prefer /bin/sh:) Line 2: # Line 3: # Copyright (C) 2014 Vinzenz Feenstra, Red Hat, Inc. Line 4: # Line 5: # Licensed under the Apache License, Version 2.0 (the "License"); Line 16: # Line 17: # Refer to the README and COPYING files for full details of the license. Line 18: # Line 19: Line 20: sudo /usr/share/ovirt-guest-agent/`basename $0`-wrapper.sh $@ quotes! Line 21: -- To view, visit http://gerrit.ovirt.org/26663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I202c1bbea8c95f5ad12edb4959a7d614c89ea246 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
