Tomas Jelinek has posted comments on this change. Change subject: frontend: spice: expose support to control the user data transfer ......................................................................
Patch Set 16: (2 comments) last small comments http://gerrit.ovirt.org/#/c/26244/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1945: boolean spiceCopyPasteToggle = isQxl && getSelectedCluster() != null Line 1946: && AsyncDataProvider.isSpiceCopyPasteToggleSupported(getSelectedCluster().getcompatibility_version().toString()); Line 1947: if (!spiceCopyPasteToggle) { Line 1948: if (isQxl) { Line 1949: getSpiceFileXferEnabled().setChangeProhibitionReason(ConstantsManager.getInstance().getMessages().optionNotSupportedClusterVersionTooOld(getSelectedCluster().getcompatibility_version().toString())); copy paste mistake :) %s/getSpiceFileXferEnabled/getSpiceCopyPasteEnabled Line 1950: } else { Line 1951: getSpiceFileXferEnabled().setChangeProhibitionReason(ConstantsManager.getInstance().getMessages().optionRequiresSpiceEnabled()); Line 1952: } Line 1953: } Line 1948: if (isQxl) { Line 1949: getSpiceFileXferEnabled().setChangeProhibitionReason(ConstantsManager.getInstance().getMessages().optionNotSupportedClusterVersionTooOld(getSelectedCluster().getcompatibility_version().toString())); Line 1950: } else { Line 1951: getSpiceFileXferEnabled().setChangeProhibitionReason(ConstantsManager.getInstance().getMessages().optionRequiresSpiceEnabled()); Line 1952: } same Line 1953: } Line 1954: getSpiceCopyPasteEnabled().setIsChangable(spiceCopyPasteToggle); Line 1955: } Line 1956: -- To view, visit http://gerrit.ovirt.org/26244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99f9f2f878171746c613598d80fdc9fdd3208ed2 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
