Greg Padgett has posted comments on this change. Change subject: use monotonic time when checking the timeouts ......................................................................
Patch Set 7: @Jiri - IIRC, the code in metadata.py to report liveness is an approximation meant to return data to the user quickly when 'hosted-engine --vm-status' is called. The agent code doing the heavy lifting employs a check to read the metadata twice, but should never compare the remote host's timestamp with the local host. Anyway, I guess it comes down to: I don't know if that change to avoid breaking the status call is needed. It may also be possible to use the monotonic time in the metadata's existing timestamp field. (I haven't looked into this, so may be wrong.) Anyway, aside from these possible considerations the change looks good to me. -- To view, visit http://gerrit.ovirt.org/26384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
