Juan Hernandez has posted comments on this change.

Change subject: restapi: spice: expose support to control the user data transfer
......................................................................


Patch Set 14: Code-Review+1

(1 comment)

Please verify.

http://gerrit.ovirt.org/#/c/26365/14/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd:

Line 2502:       <xs:element ref="certificate" minOccurs="0" maxOccurs="1"/>
Line 2503:       <xs:element name="smartcard_enabled" type="xs:boolean" 
minOccurs="0" maxOccurs="1"/>
Line 2504:       <xs:element name="keyboard_layout" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 2505:       <xs:element name="proxy" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 2506:       <xs:element name="file_xfer_enabled" type="xs:boolean" 
minOccurs="0" maxOccurs="1"/>
No need for abbreviations, please consider renaming to "file_transfer_enabled", 
is easier to read and understand.
Line 2507:       <xs:element name="copy_paste_enabled" type="xs:boolean" 
minOccurs="0" maxOccurs="1"/>
Line 2508:     </xs:sequence>
Line 2509:   </xs:complexType>
Line 2510: 


-- 
To view, visit http://gerrit.ovirt.org/26365
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I337d0b46c40f5ffe20d153707c66a83acbb2a7c1
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to