Vojtech Szocs has posted comments on this change. Change subject: webadmin: Store rest api session id in http session ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25987/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java: Line 161: Line 162: /** Line 163: * Attempts to reuse existing REST API session that was previously {@linkplain #acquireSession acquired}. Line 164: */ Line 165: public void reuseSession() { > I don't think we need to use an async version of the setSessionId when we h Thanks Alex, it's clear to me now. Line 166: getSessionId(new StorageCallback() { Line 167: Line 168: @Override Line 169: public void onSuccess(String result) { Line 177: } Line 178: Line 179: @Override Line 180: public void onFailure(Throwable caught) { Line 181: RestApiSessionManager.logger.severe("Engine REST API session ID is not available"); //$NON-NLS-1$ > severe in the standard logging mechanism doesn't have a Throwable parameter You're right. However we could still do: logger.log(Level.SEVERE, "msg", throwable); Line 182: } Line 183: }); Line 184: } Line 185: -- To view, visit http://gerrit.ovirt.org/25987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fe9af54054aefe694876b1805a4a44f9bba0482 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
