Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: bridge: support tagged VLANs and bond
......................................................................


Patch Set 5: -Verified

Partially verified:

I verified that the management bridge is successfully created on F19 with a 
single NIC

Initial configuration:

 # virsh -r net-list
 Name                 State      Autostart     Persistent
 ----------------------------------------------------------
 ;vdsmdummy;          active     no            no


ifcfg-em1
 ONBOOT=yes
 MTU=1500
 HWADDR=b8:ca:3a:76:9a:43
 TYPE=Ethernet
 BOOTPROTO=dhcp

ifcfg-em1.1
 DEVICE=em1.1
 BOOTPROTO=none
 ONBOOT=yes
 USERCTL=yes
 VLAN=yes
 IPADDR=192.168.2.1
 NETMASK=255.255.255.0




After the deployment the network config files have the following changes:

 diff --git a/ifcfg-em1.1 b/ifcfg-em1.1
 index 3233e5d..2e6282b 100644
 --- a/ifcfg-em1.1
 +++ b/ifcfg-em1.1
 @@ -1,8 +1,6 @@
 +# Generated by VDSM version 4.14.6-15.git746e2e9.fc19
 DEVICE=em1.1
 -BOOTPROTO=none
 ONBOOT=yes
 -USERCTL=yes
 VLAN=yes
 -IPADDR=192.168.2.1
 -NETMASK=255.255.255.0
 -
 +BRIDGE=ovirtmgmt
 +NM_CONTROLLED=no
 diff --git a/ifcfg-ovirtmgmt b/ifcfg-ovirtmgmt
 new file mode 100644
 index 0000000..2a69793
 --- /dev/null
 +++ b/ifcfg-ovirtmgmt
 @@ -0,0 +1,10 @@
 +# Generated by VDSM version 4.14.6-15.git746e2e9.fc19
 +DEVICE=ovirtmgmt
 +ONBOOT=yes
 +TYPE=Bridge
 +DELAY=0
 +IPADDR=192.168.2.1
 +NETMASK=255.255.255.0
 +BOOTPROTO=none
 +DEFROUTE=yes
 +NM_CONTROLLED=no

-- 
To view, visit http://gerrit.ovirt.org/25894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0abd18b3ae36265406afb80a1ee082d2d14d4a92
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to