Lior Vernia has posted comments on this change. Change subject: userportal, webadmin: fixed badly formed multi-line values. ......................................................................
Patch Set 4: (1 comment) Small comment, once that's fixed it's good to be merged on my account. http://gerrit.ovirt.org/#/c/25657/4/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 80: VDS_CANNOT_MAINTENANCE_IT_INCLUDES_NON_MIGRATABLE_VM=Cannot switch the following Hosts to Maintenance mode: ${HostsList}.\n\ Line 81: One or more running VMs are indicated as non-migratable. The non-migratable VMs are: ${VmsList}. Line 82: VDS_CANNOT_MAINTENANCE_VM_HAS_PLUGGED_DISK_SNAPSHOT=Cannot switch the following Hosts to Maintenance mode: ${HostsList}.\n\ Line 83: The following VMs cannot be migrated because they have activated Disk Snapshot attached (VM/Disk Snapshots): \n \n\ Line 84: ${disksInfo} \n \nplease deactivate/detach the Disk snapshots or turn off those VMs and try again. Not sure why two rows up you decided to add '\' and here you preferred to remove the newline (I mean, here '\' would have worked as well). Please go with one consistent rule, at least in the same error message :) Line 85: ACTION_TYPE_FAILED_OVF_DISK_NOT_SUPPORTED=Cannot ${action} ${type}. The operation is currently not supported for disks used as OVF store. Line 86: ACTION_TYPE_FAILED_DISK_NOT_IN_APPLICABLE_STATUS=Cannot ${action} ${type}. The operation can be performed only for disks that are in ${status} status. Line 87: VDS_CANNOT_REMOVE_DEFAULT_VDS_GROUP=Cannot remove default Host Cluster. Line 88: VDS_CANNOT_REMOVE_VDS_DETECTED_RUNNING_VM=Cannot ${action} ${type}. One or more VMs are still running on this Host. -- To view, visit http://gerrit.ovirt.org/25657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58f14efbc29ea7a8ba9f741175b17a62ee320f86 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
