Gilad Chaplik has posted comments on this change. Change subject: engine: Substract pendingVmSize from maxSchedulingMemory ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26707/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 1273: Line 1274: public void calculateFreeVirtualMemory() { Line 1275: if (getMemCommited() != null && getPhysicalMemMb() != null && getReservedMem() != null) { Line 1276: maxSchedulingMemory = (getMaxVdsMemoryOverCommit() * getPhysicalMemMb() / 100.0f) - Line 1277: (getMemCommited() + getReservedMem() - getPendingVmemSize()); > should be "+ getPending.." right? +1 also drop the confusing brackets Line 1278: // avoid negative values Line 1279: maxSchedulingMemory = maxSchedulingMemory > 0 ? maxSchedulingMemory : 0; Line 1280: } Line 1281: } -- To view, visit http://gerrit.ovirt.org/26707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87a0a77ae40049f18fb40d803ab58d5a7bda60f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
