Shireesh Anjal has posted comments on this change.
Change subject: engine: Reducing replica count feature in Remove brick
......................................................................
Patch Set 1: (7 inline comments)
Few comments inline, mostly related to message wording, and one additional
validation required in remove bricks command.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
Line 64: return validateBricks(getParameters().getBricks());
Add validation to make sure that stripe cannot be changed while removing
bricks, in case of stripe / distributed stripe volumes.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 740: ACTION_TYPE_FAILED_CAN_NOT_REDUCE_REPLICA_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Replica count can be reduced 1 at a time.
Message can be "Replica count cannot be reduced by more than one."
Line 741: ACTION_TYPE_FAILED_CAN_NOT_INCREASE_REPLICA_COUNT=Cannot ${action}
${type}. Replica count can not be increased.
Message can be changed to "Replica count cannot be increased when removing
bricks."
Line 742: ACTION_TYPE_FAILED_CAN_NOT_REDUCE_REPLICA_COUNT=Cannot ${action}
${type}. Replica count can not be reduced.
Message can be changed to "Replica count cannot be reduced when adding bricks."
Line 743:
ACTION_TYPE_FAILED_CAN_NOT_INCREASE_REPLICA_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Replica count can be increased 1 at a time.
Message can be changed to "Replica count cannot be increased by more than one"
Line 744: ACTION_TYPE_FAILED_CAN_NOT_INCREASE_STRIPE_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Stripe count can be increased 1 at a time.
Message can be changed to "Stripe count cannot be increased by more than one."
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1915: @DefaultStringValue("Cannot ${action} ${type}. Replica count can
be reduced 1 at a time.")
Messages can be changed as per comments in AppErrors.properties
--
To view, visit http://gerrit.ovirt.org/4970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e10d79f3b6e014b62b139c74762cb0cab72d5fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
