Alon Bar-Lev has uploaded a new change for review.
Change subject: common: pep8-1.5 fixups
......................................................................
common: pep8-1.5 fixups
Change-Id: I49751b31d2e2a14f99ca997f72ac3cd57061ddc2
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M src/otopi/main.py
M src/plugins/otopi/network/firewalld.py
M src/plugins/otopi/network/iptables.py
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/otopi refs/changes/12/26712/1
diff --git a/src/otopi/main.py b/src/otopi/main.py
index 9544317..bfad255 100644
--- a/src/otopi/main.py
+++ b/src/otopi/main.py
@@ -73,7 +73,7 @@
"""
def __init__(self):
# python2-6 has not real object
- #super(NullHandler, self).__init__()
+ # super(NullHandler, self).__init__()
logging.Handler.__init__(self)
def emit(self, record):
diff --git a/src/plugins/otopi/network/firewalld.py
b/src/plugins/otopi/network/firewalld.py
index 0eeceb3..50dabc7 100644
--- a/src/plugins/otopi/network/firewalld.py
+++ b/src/plugins/otopi/network/firewalld.py
@@ -144,7 +144,7 @@
zone_name, devices = line.split(':')
zones[zone_name] = devices.split()
else:
- #0.3.3 has changed output
+ # 0.3.3 has changed output
zone_name = None
for line in stdout:
zoneMatch = self._ZONE_RE.match(line)
diff --git a/src/plugins/otopi/network/iptables.py
b/src/plugins/otopi/network/iptables.py
index 08ce51a..b210e23 100644
--- a/src/plugins/otopi/network/iptables.py
+++ b/src/plugins/otopi/network/iptables.py
@@ -65,7 +65,7 @@
),
)
def _validate(self):
- if not self._distribution in ('redhat', 'fedora', 'centos'):
+ if self._distribution not in ('redhat', 'fedora', 'centos'):
self.logger.warning(
_('Unsupported distribution for iptables plugin')
)
--
To view, visit http://gerrit.ovirt.org/26712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49751b31d2e2a14f99ca997f72ac3cd57061ddc2
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
