Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: allow boot from host's cdrom ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26701/1/src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py File src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py: Line 89: raiseOnError=True Line 90: ) Line 91: readable = True Line 92: except RuntimeError: Line 93: readable = False > no need to set readable to False here, it is set to False by default on lin Agree, will fix Line 94: return readable Line 95: Line 96: @plugin.event( Line 97: stage=plugin.Stages.STAGE_INIT, -- To view, visit http://gerrit.ovirt.org/26701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d3f503ce6b49d11a297cd010b182b5b2804065 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
