Tomas Jelinek has uploaded a new change for review.
Change subject: engine: Fixed findbugs issue
......................................................................
engine: Fixed findbugs issue
It was a comparision of VmDeviceType and String using the equals which did
never pass. Fixed by correctly comparing the Strings
Change-Id: If587c985360b54a5fed6e72dbee2bf9c21487a33
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/26700/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
index 75b98af..59c8201 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
@@ -211,7 +211,7 @@
private boolean containsDeviceWithType(List<VmDevice> devices,
VmDeviceGeneralType generalType, VmDeviceType deviceType) {
for (VmDevice device : devices) {
if (device.getType() == generalType) {
- if (deviceType == null ||
deviceType.equals(device.getDevice())) {
+ if (deviceType == null || (deviceType.getName() != null &&
deviceType.getName().equals(device.getDevice()))) {
return true;
}
}
--
To view, visit http://gerrit.ovirt.org/26700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If587c985360b54a5fed6e72dbee2bf9c21487a33
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
