Dhandapani Gopal has posted comments on this change.
Change subject: restapi: Gluster Volume Bricks resource implementation
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2655: <xs:element name="new_stripe_count" type="xs:unsignedShort"
minOccurs="0" maxOccurs="1"/>
Done
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
Line 45: try {
Done
Line 103: return
performCreationMultiple(VdcActionType.AddBricksToGlusterVolume,
performCreation() calls resolveCreated(), which expects
result.getActionReturnValue() to return a Guid.
In our case, the command returns List<Guid>, and hence performCreation() won't
work as is. So I've introduced a new method resolveCreatedList(), which
populates the list of bricks in the GlusterBricks object it returns. The only
different thing that performCreationMultiple() does is calling
resolveCreatedList() instead of resolveCreated(), and removing the asyncTasks
support as the "add bricks" operation is always synchronous.
Line 152: public Response remove(GlusterBricks bricks) {
Done
--
To view, visit http://gerrit.ovirt.org/4909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab5fc0dd5ef9c2d3eadbc7e78876079c61f46cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
