Yair Zaslavsky has posted comments on this change. Change subject: core: Engine is sending bad credentials repeatdely ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26664/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java: Line 140: ldapCredentials.getUserName(), Line 141: translatedException, Line 142: handlingResponse.isTryNextServer() ? "should" : "should not"); Line 143: if (!handlingResponse.isTryNextServer()) { Line 144: throw new Exception(); > Would it be better to throw RuntimeException instead? Also it would be good well, i was in a dilema if to throw RuntimeException or not... i do want to catch the exception where it is caught, so i don't see any real benefit to RuntimeException. And when it comes to the message - well, there is already logging that we should not try next server, so what will i gain from it? Line 145: } Line 146: } Line 147: return null; Line 148: } -- To view, visit http://gerrit.ovirt.org/26664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c04d586a776b469f0e619d3ea0ff844ea07a357 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
