Allon Mureinik has posted comments on this change. Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4 ......................................................................
Patch Set 2: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/26661/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java: Line 117: DefaultMaximumMigrationDowntime, Line 118: IsMigrationSupported(ConfigAuthType.User), Line 119: IsMemorySnapshotSupported(ConfigAuthType.User), Line 120: IsSuspendSupported(ConfigAuthType.User), Line 121: SerialNumberPolicySupported, I assume this is a cherry-picking foobar? Line 122: IscsiMultipathingSupported; Line 123: Line 124: public static enum ConfigAuthType { Line 125: Admin, http://gerrit.ovirt.org/#/c/26661/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 217: select fn_db_add_config_value('DefaultRouteSupported','false','3.0'); Line 218: select fn_db_add_config_value('DefaultRouteSupported','false','3.1'); Line 219: select fn_db_add_config_value('DefaultRouteSupported','false','3.2'); Line 220: select fn_db_add_config_value('DefaultRouteSupported','false','3.3'); Line 221: <<<<<<< HEAD cherry pick failure. Line 222: Line 223: -- Mixed domain types in a data center support Line 224: select fn_db_add_config_value('MixedDomainTypesInDataCenter','false','3.0'); Line 225: select fn_db_add_config_value('MixedDomainTypesInDataCenter','false','3.1'); Line 230: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.0'); Line 231: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.1'); Line 232: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.2'); Line 233: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.3'); Line 234: select fn_db_add_config_value('SerialNumberPolicySupported','false','3.4'); unrelated. Line 235: Line 236: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.0'); Line 237: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.1'); Line 238: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.2'); Line 236: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.0'); Line 237: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.1'); Line 238: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.2'); Line 239: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.3'); Line 240: select fn_db_add_config_value('OvfStoreOnAnyDomain','false','3.4'); unrelated. Line 241: Line 242: select fn_db_add_config_value('IscsiMultipathingSupported','false','3.0'); Line 243: select fn_db_add_config_value('IscsiMultipathingSupported','false','3.1'); Line 244: select fn_db_add_config_value('IscsiMultipathingSupported','false','3.2'); -- To view, visit http://gerrit.ovirt.org/26661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I623cd917ca0871a9d3d09c2d30ec2dfc114d383e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
