Martin Mucha has posted comments on this change. Change subject: engine: add audit log warning when display network is set and a running VM is attached to the cluster (for AttachNetworksToCluster command). ......................................................................
Patch Set 4: Code-Review+1 (1 comment) I place one comment how to make code a little bit cleaner, but aside from that I think it's ok. http://gerrit.ovirt.org/#/c/26504/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java: Line 205: Line 206: getReturnValue().getCanDoActionMessages().addAll(messages); Line 207: return false; Line 208: } Line 209: when method on a class like this have to be static to be available to another class, which just want to call this method without having instance of first that class indicates, that *this* static method should belong to common super class of both mentioned class (if that's wise/possible) or to some helper class. In this case, as passing 'this' into static method indicates, this should not be static method, but method on common (newly created) superclass instead. With this method would go away both static methods at the end of this file. --- I do not insist on this fix, it's completely upon you, but it would be cleaner that way. Line 210: public static void updateNetworkAttachment( Line 211: Guid clusterId, Line 212: NetworkCluster networkCluster, Line 213: Network network, -- To view, visit http://gerrit.ovirt.org/26504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674f7f7a905e3007e9857dd817e125e52d02c448 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
