Martin Peřina has posted comments on this change. Change subject: tools: Add runtime log4j setup to engine-config ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26591/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java: Line 35: level = Level.toLevel(levelName, null); Line 36: if (level == null) { Line 37: throw new IllegalArgumentException(String.format("Invalid log level value: '%s'", levelName)); Line 38: } Line 39: } > all I wrote is that the exception handling should be at function level... n Martin: >I don't validate command line args for --log-file and --log-level, validation >is part of this function. Alon: >yes, but why don't you? So, you want me to move Level validation (lines 33-39) into Log4jUtils.addAppender, right? Line 40: Log4jUtils.addFileAppender(fileName, level); Line 41: } Line 42: } Line 43: public static void main(String... args) { -- To view, visit http://gerrit.ovirt.org/26591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328a018ef1b714c6a90d1b219dcd326a16bcab2d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
