Sandro Bonazzola has posted comments on this change. Change subject: Clean the code to pass pep8 checks ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26314/4/src/__main__.py File src/__main__.py: Line 546: ) Line 547: else: Line 548: logging.debug( Line 549: "the storage domain didn't have a status " Line 550: "element.") new line with ')' Line 551: else: Line 552: logging.debug( Line 553: _("DC(%s) does not have a storage domain.") % dcName) Line 554: if len(imageAry) > 0: Line 549: "the storage domain didn't have a status " Line 550: "element.") Line 551: else: Line 552: logging.debug( Line 553: _("DC(%s) does not have a storage domain.") % dcName) same here and in the rest of the file Line 554: if len(imageAry) > 0: Line 555: imageAry.sort(key=get_name) Line 556: fmt = "%-30s | %-25s | %s" Line 557: print fmt % ( -- To view, visit http://gerrit.ovirt.org/26314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b37c4a5c2449a93a4bc8b90d74301b66ae945e3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
