Yair Zaslavsky has posted comments on this change. Change subject: aaa: ExtensionsManager: use the new extensions api ......................................................................
Patch Set 25: (1 comment) http://gerrit.ovirt.org/#/c/26427/25/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 165: } Line 166: } Line 167: Line 168: private List<String> splitString(String s) { Line 169: return Arrays.asList(s.trim().split("\\s*,\\s*", 0)); > please address this comment. yes, i addressed it somewhere else, and already fixed. didn't i wrote something like "bad java" in my first explanation? :) Line 170: } Line 171: Line 172: private synchronized void loadImpl(Properties props, File confFile) { Line 173: ExtensionEntry entry = new ExtensionEntry(props, confFile); -- To view, visit http://gerrit.ovirt.org/26427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d170d5dda990fd85e9843ecbb4909749a88df75 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
