Yair Zaslavsky has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the extension API ......................................................................
Patch Set 19: (1 comment) http://gerrit.ovirt.org/#/c/26443/19/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 46: Line 47: private void doInit(ExtMap input, ExtMap output) { Line 48: context = input.<ExtMap> get(Base.InvokeKeys.CONTEXT); Line 49: List<String> keys = new ArrayList<>(context.<List<String>> get(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS)); Line 50: keys.add("config.authn.user.password"); > can you please explain why the following does not work? Yes, I thought I have written it somewhere :) the value in this map entry is of type Arrays.ArrayList (this is not java.util.ArrayList, don't get confused!) , the add operation is not supported. However, now that I look at this code again, it would be better to change - private List<String> ExtensionsManager.splitString to be - private List<String> ExtensionsManager.splitString(String s) { return new ArrayList<String>(Arrays.asList(s.trim().split("\\s*,\\s*", 0))); } and then we can remove the temp variable. Line 51: context.mput( Line 52: Base.ContextKeys.AUTHOR, Line 53: "The oVirt Project").mput( Line 54: Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS, -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
