Greg Padgett has posted comments on this change. Change subject: engine: remove unused notification config options ......................................................................
Patch Set 1: Hi Yair, thanks for looking it over. I removed the 3 calls to fn_db_add_config_value and added 3 fn_db_delete_config_value calls to the section labelled "Cleanup deprecated configuration values section". I didn't see another place to put config values that should be deleted. I tested via upgrade as well, and confirmed that the ENMail* values were in vdc_options before the upgrade and were not there after installing with my changes. If I am misunderstanding, can you point me more specifically to the correct place to make the changes? Thanks again. -- To view, visit http://gerrit.ovirt.org/4876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74649c66eff1713b60fa5d44487dd86cfa96cd21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
