Mike Kolesnik has posted comments on this change.
Change subject: core: UnPowerMock validator tests
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java
Line 32: public void mockConfig(int maxMTU) {
Why not inline in setup?
Or, alternatively, the 9000 MTU should not be passed as parameters (probably
should be a constant).
--
To view, visit http://gerrit.ovirt.org/4937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I770362f4f64c89ad27ddcf266d6526b690faf9c2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
