Alon Bar-Lev has posted comments on this change. Change subject: tools: Add runtime log4j setup to engine-config ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26591/1/backend/manager/tools/src/main/resources/engine-config/log4j.xml File backend/manager/tools/src/main/resources/engine-config/log4j.xml: Line 3: <!DOCTYPE log4j:configuration SYSTEM "log4j.dtd"> Line 4: Line 5: <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/";> Line 6: <root> Line 7: <level value="OFF"/> > Why NullAppender is better then level set to OFF? because when you add appender you should not touch the root logger. imagine we add several, each one complete on what root is. adding NullAppender is local workaround for the log4j issue, which should not effect the way you write your code. if in future it will be resolved all you need is to remove this extra appender. Line 8: </root> Line 9: -- To view, visit http://gerrit.ovirt.org/26591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328a018ef1b714c6a90d1b219dcd326a16bcab2d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
