Tomas Jelinek has posted comments on this change. Change subject: core: Set Sysprep domain to editable field ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/26500/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 1336: vm.getPropertyChangedEvent().addListener(new IEventListener() { Line 1337: @Override Line 1338: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 1339: String propName = ((PropertyChangedEventArgs) args).propertyName; Line 1340: if ("IsWindowsOS".equals(propName)) { //$NON-NLS-1$ this whole statement can be deleted Line 1341: } else if ("IsGeneralTabValid".equals(propName)) { //$NON-NLS-1$ Line 1342: if (vm.getIsGeneralTabValid()) { Line 1343: generalTab.markAsValid(); Line 1344: } else { http://gerrit.ovirt.org/#/c/26500/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java: Line 466: userLocaleEditor.addStyleName(customizableStyle.primaryOption()); Line 467: userNameEditor.addStyleName(customizableStyle.primaryOption()); Line 468: hostnameEditor.addStyleName(customizableStyle.primaryOption()); Line 469: windowsHostnameEditor.addStyleName(customizableStyle.primaryOption()); Line 470: cloudInitDomainEditor.addStyleName(customizableStyle.primaryOption()); does the sysprepDomainEditor render properly for both run and run once? No need to give it a style name? Line 471: timeZoneEnabledEditor.addStyleName(customizableStyle.primaryOption()); Line 472: timeZoneEditor.addStyleName(customizableStyle.primaryOption()); Line 473: rootPasswordEditor.addStyleName(customizableStyle.primaryOption()); Line 474: rootPasswordVerificationEditor.addStyleName(customizableStyle.primaryOption()); http://gerrit.ovirt.org/#/c/26500/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java: Line 655: } else { Line 656: getHostname().validateEntity(new IValidation[] { new HostnameValidation() }); Line 657: } Line 658: } Line 659: getCloudInitDomain().setIsValid(true); - no need to validate also sysprep domain? - the cloud init domain seems to not be validated either - only set to valid right at the beginning. Is that correct? Can you put whatever to that field? Line 660: Line 661: getAuthorizedKeys().setIsValid(true); Line 662: Line 663: getTimeZoneList().setIsValid(true); -- To view, visit http://gerrit.ovirt.org/26500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0370e63593035e80851852dca40a480fdccf46fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
