Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing Directory and Authenticator proxies ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/26567/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorProxy.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorProxy.java: Line 55: Line 56: @Override Line 57: @Deprecated Line 58: public boolean isNegotiationAuth() { Line 59: return extension.getContext().get(Authn.ContextKeys.CAPABILITIES).equals(Authn.Capabilities.AUTHENTICATE_NEGOTIATE); should be bitwise and Line 60: } Line 61: Line 62: @Override Line 63: @Deprecated Line 61: Line 62: @Override Line 63: @Deprecated Line 64: public boolean isPasswordAuth() { Line 65: return extension.getContext().get(Authn.ContextKeys.CAPABILITIES).equals(Authn.Capabilities.AUTHENTICATE_PASSWORD); should be bitwise and Line 66: } Line 67: Line 68: } http://gerrit.ovirt.org/#/c/26567/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java: Line 105: Authz.InvokeKeys.QUERY, Line 106: new ExtMap().mput( Line 107: Authz.QueryRecord.LDAP_QUERY, Line 108: query Line 109: ) you need to set QueryRecordEntities Line 110: ) Line 111: ); Line 112: } Line 113: Line 164: }); Line 165: return directoryGroups; Line 166: } Line 167: Line 168: private void queryImpl(QueryResultHandler handler) { well, you can pass the command and the input map as parameters instead via the sink, the sink should be only for notifications. Line 169: try { Line 170: queryOpaque = extension.invoke( Line 171: new ExtMap().mput( Line 172: Base.InvokeKeys.COMMAND, Line 185: ).get(Authz.InvokeKeys.QUERY_RESULT); Line 186: if (result == null) { Line 187: break; Line 188: } Line 189: handler.handle(result); I still think that: if (!handler.handle(result)) { break; } and... while we at it... avoid break.... do { bla bla bla bla while(result != null && handler.handle(result); Line 190: } Line 191: } finally { Line 192: extension.invoke(new ExtMap().mput( Line 193: Base.InvokeKeys.COMMAND, -- To view, visit http://gerrit.ovirt.org/26567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd2bfbfe1bb7ace7a6e16d5117f20c476590eee1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
