Alon Bar-Lev has posted comments on this change. Change subject: aaa: using the extension API at InternalDirectory ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/26477/13/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java: Line 76: ); Line 77: } Line 78: } Line 79: Line 80: private void doQueryExecute(ExtMap input, ExtMap output) { > please consider to return this only when asking to fetch user and query mat not that important as the engine will ignore principal if it looks for group. however if we search for x and get admin we are in problem. Line 81: Opaque opaque = input.<Opaque> get(Authz.InvokeKeys.QUERY_OPAQUE); Line 82: output.put(Authz.InvokeKeys.QUERY_RESULT, opaque.firstCall ? Arrays.asList(adminUser) : null); Line 83: opaque.firstCall = false; Line 84: } -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
