Yaniv Dary has posted comments on this change. Change subject: reports: edited ic query-only_storage_name ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/26295/3/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_StorageDomain_ID.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_StorageDomain_ID.xml: Line 53: -- Here we join storage domain config table with Line 54: -- the storage domains and datacenter map table. Line 55: -- We also filter by the datacenter chosen by the user Line 56: v3_4_configuration_history_storage_domains Line 57: INNER JOIN v3_4_map_history_datacenters_storage_domains should be indented by one more tab Line 58: ON ( Line 59: v3_4_map_history_datacenters_storage_domains.storage_domain_id = Line 60: v3_4_configuration_history_storage_domains.storage_domain_id Line 61: AND v3_4_map_history_datacenters_storage_domains.datacenter_id = Line 60: v3_4_configuration_history_storage_domains.storage_domain_id Line 61: AND v3_4_map_history_datacenters_storage_domains.datacenter_id = Line 62: CAST ( $P{P_DataCenter_ID} AS uuid ) Line 63: ) Line 64: LEFT OUTER JOIN ( also Line 65: SELECT DISTINCT Line 66: COALESCE ( Line 67: enum_translator_localized.value_localized, Line 68: enum_translator_default.value Line 89: ON ( 0 = 0 ) Line 90: WHERE Line 91: --Here we filter by the storage type chosen by the user Line 92: v3_4_configuration_history_storage_domains.storage_domain_type = Line 93: CASE CAST ( $P{P_Storage_Type} AS int ) also Line 94: WHEN NULL Line 95: THEN v3_4_configuration_history_storage_domains.storage_domain_type Line 96: WHEN -1 Line 97: THEN v3_4_configuration_history_storage_domains.storage_domain_type Line 122: END Line 123: -- Here we get if to filter deleted entities or not Line 124: -- according to what the user chose Line 125: $P!{active_storage} Line 126: ORDER BY detach_date DESC, combo_name please put each column in a separate row Line 127: </queryString> Line 128: <dataSource> Line 129: <uri>/reports_resources/JDBC/data_sources/ovirt</uri> Line 130: </dataSource> -- To view, visit http://gerrit.ovirt.org/26295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24c6d3cfe7549f122eed779ec28427177b6f2d86 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
