Mike Kolesnik has posted comments on this change. Change subject: core: UnPowerMock GetoVirtISOsTest ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java Line 31: private static String OVIRT_ISO_PREFIX; This name should not be in uppercase (constants) convention if it is not final... Line 205: // (for performance), and with the reloadable configuration feature, the value of the config may change I didn't understand, in this case won't it be better to get the value from the configuration if it is indeed reloadable? You can recompile if the pattern had changed (easy enough to detect). Also, why not javadoc? -- To view, visit http://gerrit.ovirt.org/4930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3935138a255a5e91750543b35105e88d0e517084 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
