Shirly Radco has posted comments on this change.

Change subject: reports: br22 report - added comments to queries
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/24801/6/packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/full+details.jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/full
 details.jrxml.data:

Line 96:                     value AS value_localized
Line 97:                 FROM enum_translator
Line 98:                 WHERE language_code = $P{P_Locale}
Line 99:             )
Line 100:             AS enum_translator_localized 
> trailing whitespace
Done
Line 101:               ON (
Line 102:                 enum_translator_localized.enum_type =
Line 103:                 enum_translator_default.enum_type
Line 104:                 AND enum_translator_localized.enum_key =


http://gerrit.ovirt.org/#/c/24801/6/packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data:

Line 143
Line 144
Line 145
Line 146
Line 147
> Why is WHERE indented?
Done


-- 
To view, visit http://gerrit.ovirt.org/24801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I377ed12395c144d814af6c86212bf4755f0bb3aa
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to