Alon Bar-Lev has posted comments on this change. Change subject: aaa: introducing the extension api ......................................................................
Patch Set 15: (2 comments) I do not like the format changes... or this was a complete revert. please cherry-pick next time... I will send a new patch. http://gerrit.ovirt.org/#/c/26435/15/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java: Line 160: for (Map.Entry<? extends ExtKey,? extends Object> entry : m.entrySet()) { Line 161: put(entry.getKey(), entry.getValue()); Line 162: } Line 163: } Line 164: ? Line 165: /** Line 166: * Multiple putAll. Line 167: * Usable for adding multiple maps: Line 168: * <pre>{@code http://gerrit.ovirt.org/#/c/26435/15/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java: Line 141: * <p> Line 142: * Input: Line 143: * <ul> Line 144: * <li>{@link InvokeKeys#QUERY}[M]</li> Line 145: * <li>{@link Authn.InvokeKeys#RESOLVE_GROUPS_RECURSIVE}[M] - resolve groups recursively.</li> this was not reverted. Line 146: * </ul> Line 147: * </p> Line 148: * Line 149: * <p> -- To view, visit http://gerrit.ovirt.org/26435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d70daf5e1fc7875458d9091cc814de817223aa0 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
