Tomas Jelinek has uploaded a new change for review.

Change subject: userportal: Edit VM on UP fails on NPE
......................................................................

userportal: Edit VM on UP fails on NPE

The regression has been introduced by the SerialNumber feature:
72fcf57dc92d4e5469b1911cb5b3b42e433bd784

which adds the possibility to edit the serial number also to the UP but the
query which is supposed to return, if the serial number is supported for the
specific version is not a user query leading to a NPE in AbstractVmPopupWidget
where the isSerialNumberPolicySupported was being converted to boolean. And
since it was null, this conversion failed on NPE.

Change-Id: Ifdd13ded70e3b4abb17c114ebbe86b11a3ef31ea
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/26524/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
index fb46f72..079766e 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
@@ -118,7 +118,7 @@
     IsMigrationSupported(ConfigAuthType.User),
     IsMemorySnapshotSupported(ConfigAuthType.User),
     IsSuspendSupported(ConfigAuthType.User),
-    SerialNumberPolicySupported,
+    SerialNumberPolicySupported(ConfigAuthType.User),
     IscsiMultipathingSupported;
 
     public static enum ConfigAuthType {


-- 
To view, visit http://gerrit.ovirt.org/26524
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdd13ded70e3b4abb17c114ebbe86b11a3ef31ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to