Allon Mureinik has uploaded a new change for review. Change subject: core: UnPowerMock RemoveAdGroupCommandTest ......................................................................
core: UnPowerMock RemoveAdGroupCommandTest Removed PowerMock dependency from RemoveAdGroupCommandTest, and replaced it with spying the command's relevant method. In order to achieve this improvement a small refactoring was required in RemoveAdGroupCommand. CanRemoveAdGroup was turned into a private instance method (instead of a static public one), and isLastSuperUserGroup was extracted so the MultiLevelAdministrationHandler dependecy could be mocked away. Change-Id: Icf5d7eb0e15c92a43b88f7705754ca8238a48d97 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAdGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAdGroupCommandTest.java 2 files changed, 22 insertions(+), 83 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/4932/1 -- To view, visit http://gerrit.ovirt.org/4932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf5d7eb0e15c92a43b88f7705754ca8238a48d97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
