Martin Peřina has posted comments on this change. Change subject: core: Distinguish between manual fence resulted.. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26385/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java: Line 117: } Line 118: else { Line 119: return _fenceSpmCalled != null && !_fenceSpmCalled ? AuditLogType.VDS_MANUAL_FENCE_FAILED_CALL_FENCE_SPM Line 120: : getSucceeded() ? AuditLogType.VDS_MANUAL_FENCE_STATUS : AuditLogType.VDS_MANUAL_FENCE_STATUS_FAILED; Line 121: } Maybe this formatting would make the code more readable: if (isInternalExecution()) { return _fenceSpmCalled != null && !_fenceSpmCalled ? AuditLogType.VDS_AUTO_FENCE_FAILED_CALL_FENCE_SPM : getSucceeded() ? AuditLogType.VDS_AUTO_FENCE_STATUS : AuditLogType.VDS_AUTO_FENCE_STATUS_FAILED; } else { return _fenceSpmCalled != null && !_fenceSpmCalled ? AuditLogType.VDS_MANUAL_FENCE_FAILED_CALL_FENCE_SPM : getSucceeded() ? AuditLogType.VDS_MANUAL_FENCE_STATUS : AuditLogType.VDS_MANUAL_FENCE_STATUS_FAILED; } Line 122: } Line 123: Line 124: /** Line 125: * Determines whether VDS [is legal status] [the specified status]. -- To view, visit http://gerrit.ovirt.org/26385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
