Oved Ourfali has posted comments on this change. Change subject: core: resolve NPE in VM/Template Export ......................................................................
Patch Set 1: Looks good to me, approved (2 inline comments) If you want you can use StringUtils helpers here, but it is up to you. Oved .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java Line 251: : UsbPolicy.DISABLED.name()); You can use some StringUtils helper here. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java Line 332: _writer.WriteRaw(vmBase.getusb_policy() != null ? vmBase.getusb_policy().toString() : UsbPolicy.DISABLED.name()); You can use a StringUtils helper here. -- To view, visit http://gerrit.ovirt.org/4920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6794924558892a4f6999dc0f2257355bae9ca1a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
