Alon Bar-Lev has posted comments on this change. Change subject: aaa: using the new extensions API in InternalDirectory ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/26477/8/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java: Line 79: Line 80: @Deprecated Line 81: @Override Line 82: public List<DirectoryUser> queryUsers(String query) { Line 83: return populateUsers(extension.invoke( why do you invoke here? Line 84: new ExtMap().mput( Line 85: Base.InvokeKeys.COMMAND, Line 86: Authz.InvokeCommands.QUERY_PRINCIPALS_OPEN Line 87: ).mput( Line 94: @Deprecated Line 95: @Override Line 96: public List<DirectoryGroup> queryGroups(String query) { Line 97: return populateGroups( Line 98: extension.invoke( same? Line 99: new ExtMap().mput( Line 100: Base.InvokeKeys.COMMAND, Line 101: Authz.InvokeCommands.QUERY_GROUPS_OPEN Line 102: ).mput( -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
