Alon Bar-Lev has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the new extensions API ......................................................................
Patch Set 11: (1 comment) great, code is ok, although indentation is horrible. http://gerrit.ovirt.org/#/c/26443/11/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 49: mput( Line 50: Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS, Line 51: context.<List<String>> get(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS) Line 52: .add("config.authn.user.password") Line 53: ). indent is all wrong... I guess you need to move the mput near the dot to make it some sense... please try to find a way to indent these statements so both humans and the ide will be happy. Line 54: mput(Base.ContextKeys.EXTENSION_NAME, "Internal Authentication (Built-in"). Line 55: mput(Base.ContextKeys.LICENSE, "ASL 2.0"). Line 56: mput(Base.ContextKeys.HOME_URL, "http://www.ovirt.org";). Line 57: mput(Base.ContextKeys.VERSION, "N/A"). -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
