Allon Mureinik has posted comments on this change. Change subject: restapi: Validate dest when importing template ......................................................................
Patch Set 2: Code-Review-1 @Juan/Michael - Yes, you should be able to have a default destination ID that should be used if a certain disk (or all of them) are missing a destination. If this no longer happens, it's a bug in the backend command, that should be fixed there. The validation should be either provide a default, or the full map. IMHO, this too should be done in the backend, it sounds a bit too "business-logicy" for the API layer. -- To view, visit http://gerrit.ovirt.org/26127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cf2d94514b159c34f19a7f0377fcb2a9afd1c19 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches