Daniel Erez has posted comments on this change. Change subject: restapi: VmHelper isn't a resource ......................................................................
Patch Set 1: IIRC, VmHelper had to be added as a resource just in order to update its properties (setMessageBundle/setBackend/etc). Otherwise, invoking 'getEntity' from within the helper would cause an NPE [1]. Have you verified that the functionality introduced in [2] doesn't require that change any more (I think that simply creating a new VM caused the NPE - I'll try to reproduce it again). @Ori - do you recall if this change was indeed mandatory or did we have some alternative solution for it? [1] http://pastebin.com/xmJT6Y4x [2] http://gerrit.ovirt.org/#/c/19154/16 -- To view, visit http://gerrit.ovirt.org/26432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4865a2266d7a17615896582100e1e4dfa16482b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
