Alexander Wels has posted comments on this change. Change subject: webadmin: System tree refresh ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26161/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemModel.java: Line 130: return false; Line 131: } Line 132: } else { Line 133: if (otherModel.getEntity() != null && otherModel.getEntity().equals(getEntity()) Line 134: && otherModel.getTitle().equals(getTitle())) { > the comparison should only be done if there are no children or if we don't I see your point now, based on the flag either the children get compared but not the item models themselves or the item models get compared but not the models. The models should always be compared regardless of the flag. Fixing. Line 135: return true; Line 136: } Line 137: return false; Line 138: } -- To view, visit http://gerrit.ovirt.org/26161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I062163b1f6d2e5fcfd1539b69a3d0d2cee674654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
