Alexander Wels has uploaded a new change for review. Change subject: webadmin: system tree item selection ......................................................................
webadmin: system tree item selection - Automatically select the first item in a grid when refreshing the grid AND there is only one item in the grid. Change-Id: Ibee9fc961a1e65606934e4f25d4a4e6fff0024b8 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/26431/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java index 73f8155..9ff827f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java @@ -151,6 +151,9 @@ public void setRowData(int start, List<? extends T> values) { super.setRowData(start, values); selectionModel.resolveChanges(); + if (!values.isEmpty() && selectionModel.getSelectedList().isEmpty()) { + selectionModel.setSelected(values.get(0), true); + } updateTableControls(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java index 38c6952..30e9d19 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java @@ -889,7 +889,7 @@ } else if (vmList.isSearchStringMatch(source)) { - prefix.argvalue = "Vms: Hosts.name = " + model.getTitle(); //$NON-NLS-1$ + prefix.argvalue = "Vms: Host = " + model.getTitle(); //$NON-NLS-1$ } else if (templateList.isSearchStringMatch(source)) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java index 2120596..9e0fa0e 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java @@ -123,7 +123,7 @@ @Override protected void moveSelectionDown() { // Make sure that the menu is actually showing and focus the selected item - if (suggestionPopup.isShowing()) { + if (suggestionPopup != null && suggestionPopup.isShowing()) { suggestionsTable.focusItemByIndex(suggestionsTable.getSelectedItemIndex()); if (suggestionsTable.getSelectedItemIndex() == 0) { -- To view, visit http://gerrit.ovirt.org/26431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibee9fc961a1e65606934e4f25d4a4e6fff0024b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
