Sandro Bonazzola has posted comments on this change. Change subject: use monotonic time when checking the timeouts ......................................................................
Patch Set 2: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/26384/2/ovirt_hosted_engine_ha/agent/state_data.py File ovirt_hosted_engine_ha/agent/state_data.py: Line 86: area = (b - a)(f(a) + f(b))/2 Line 87: where a,b are timestamps and f(a) and f(b) are values Line 88: """ Line 89: Line 90: def trapezoid(acc, point): # point is StatsData """ Keyword arguments: - acc -- ..... - point -- ... is StatsData ... """ Line 91: area, time, last_load, last_time = acc Line 92: cur_load = point.local["cpu-load"] Line 93: cur_time = point.collect_start Line 94: if cur_load is not None and last_load is not None: http://gerrit.ovirt.org/#/c/26384/2/ovirt_hosted_engine_ha/agent/state_machine.py File ovirt_hosted_engine_ha/agent/state_machine.py: Line 1: __author__ = 'msivak' Line 2: Missing license header and module doc Line 3: from ..lib.fsm import BaseFSM, BaseState Line 4: from ..lib import util Line 5: from ..lib.util import engine_status_score Line 6: from . import constants http://gerrit.ovirt.org/#/c/26384/2/ovirt_hosted_engine_ha/lib/Makefile.am File ovirt_hosted_engine_ha/lib/Makefile.am: Line 35: storage_backends.py \ Line 36: storage_backends_test.py \ Line 37: util.py \ Line 38: vds_client.py \ Line 39: monotonic.py missing trailing \ Line 40: $(NULL) Line 41: Line 42: SUBDIRS = \ Line 43: fsm \ http://gerrit.ovirt.org/#/c/26384/2/ovirt_hosted_engine_ha/lib/monotonic.py File ovirt_hosted_engine_ha/lib/monotonic.py: Line 1: __all__ = ["time"] missing License header and module documentation Line 2: Line 3: import ctypes Line 4: import os Line 5: import logging -- To view, visit http://gerrit.ovirt.org/26384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
