Moti Asayag has posted comments on this change. Change subject: engine: event on interface status change ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26104/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 725: if (StringUtils.isNotEmpty(iface.getNetworkName()) || NetworkUtils.isLabeled(iface)) { Line 726: VdsNetworkInterface parentIface = iface; Line 727: // If vlan find the parent interface Line 728: if (iface.getVlanId() != null) { Line 729: Map<String, VdsNetworkInterface> interfaceByName = Entities.entitiesByName(interfaces); > Maybe construct this map out of the loop? +1 asked the same on patchset #2. Line 730: parentIface = interfaceByName.get(parentIfaceName); Line 731: } Line 732: Line 733: monitoredInterfaces.put(parentIfaceName, parentIface); -- To view, visit http://gerrit.ovirt.org/26104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76953e4b52e35d2e18b6bc68051fa7dd6f3db129 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
