Oved Ourfali has posted comments on this change. Change subject: engine : Failed approved RHEVH for rhev3.2 host in rhevm av4 with Data Centers 3.2 + 3.2 Cluster ......................................................................
Patch Set 2: Code-Review+2 (2 comments) minor comments. http://gerrit.ovirt.org/#/c/26409/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java: Line 114: vds.setCpuName(CpuFlagsManagerHandler.FindMaxServerCpuByFlags(vds.getCpuFlags(), Line 115: getTargetCluster().getcompatibility_version())); Line 116: Line 117: Line 118: // CPU flags are empty if we change oVrt node cluster during approve process s/ovrt/ovirt Line 119: if (vds.getCpuFlags() != null) { Line 120: if (vds.getCpuName() == null) { Line 121: return failCanDoAction(VdcBllMessages.CPU_TYPE_UNSUPPORTED_IN_THIS_CLUSTER_VERSION); Line 122: } Line 115: getTargetCluster().getcompatibility_version())); Line 116: Line 117: Line 118: // CPU flags are empty if we change oVrt node cluster during approve process Line 119: if (vds.getCpuFlags() != null) { just making sure, it will be null, not empty, right? If so, change the comment accordingly (s/empty/null). If it can be empty then check for StringUtils.isEmpty or something similar. Line 120: if (vds.getCpuName() == null) { Line 121: return failCanDoAction(VdcBllMessages.CPU_TYPE_UNSUPPORTED_IN_THIS_CLUSTER_VERSION); Line 122: } Line 123: -- To view, visit http://gerrit.ovirt.org/26409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f485ce0512ae9c35be5b3f803b7ca1c35dea4f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
