Doron Fediuck has posted comments on this change.
Change subject: webadmin: cpu pinning support
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Gilad, the explanation label needs to be fixed.
Also, please see the other comment, which I will enforce in future patches.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 899: @DefaultStringValue("v1#p1_v2#p2_..._v<n>#p<n>, Examples: 0#0,
1#3, 1#4, ^2")
Please remove the space before '^2'.
It should look like this:
1-4,^2
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 934: VdcQueryType.GetDefualtTimeZone,
Gilad, please correct me if I'm wrong, but this line did not really change
other than formatting.
If this is the case, than please avoid it. Reformatting and refactoring should
be done isn separate patches, as this makes reviewing much harder.
--
To view, visit http://gerrit.ovirt.org/4836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88f54404717b3f5002ef502be2ce14e89b5144f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
