Liron Ar has posted comments on this change. Change subject: core: make clear use of filterImage ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25349/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java: Line 543: public static List<DiskImage> filterOutShareableDisks(Collection<? extends Disk> listOfDisks) { Line 544: return filterImageDisks(listOfDisks, true, false, false); Line 545: } Line 546: Line 547: public static List<DiskImage> filterOutShareableAndNotSnapsableAndNotActiveDisks(Collection<? extends Disk> listOfDisks) { > The patch follows what commit message describes. there is nothing to discus this patch adds several proxy methods here which half of them are unneeded as one of the parameters is irrelevant. if you want to simplify the code here the solution would be to remove the uneeded parameter (snappable/shareable) which means the same thing and than it might be clear enough even without adding proxy methods for unneeded permutations. Line 548: return filterImageDisks(listOfDisks, true, true, true); Line 549: } Line 550: Line 551: public static List<DiskImage> filterOutShareableAndNotSnapsableDisks(Collection<? extends Disk> listOfDisks) { -- To view, visit http://gerrit.ovirt.org/25349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54a22319d7005449ec4c3ecd285d81870b1c307e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
