mooli tayer has posted comments on this change. Change subject: backend: logging change in VdsManager. ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26141/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 483: if (vds.getStatus() == VDSStatus.Error) { Line 484: mFailedToRunVmAttempts.set(0); Line 485: setStatus(VDSStatus.Up, vds); Line 486: DbFacade.getInstance().getVdsDynamicDao().updateStatus(getVdsId(), VDSStatus.Up); Line 487: log.infoFormat("Settings host {0} to up after {1} failed attempts to run a VM", vds.getName(), > well i wrote this in the patch with the bug fix, but again here: mFailedToRunVmAttempts.set(0); should come after this line, and then the vds.getName() is the exact number of calls to failedToRunVm. will fix in the relevant patch. Line 488: mFailedToRunVmAttempts); Line 489: } Line 490: } Line 491: -- To view, visit http://gerrit.ovirt.org/26141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25dc387dfa6b9499115bcd811c9bffb45b09e996 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
