Omer Frenkel has posted comments on this change. Change subject: core: log exception when OVF is corrupted ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/26087/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetAllFromExportDomainQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetAllFromExportDomainQuery.java: Line 68: parameters.setStorageDomainId(storage.getId()); Line 69: parameters.setVmIdList(getParameters().getIds()); Line 70: return parameters; Line 71: } Line 72: enter? http://gerrit.ovirt.org/#/c/26087/5/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java File backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java: Line 44: } Line 45: Line 46: outerXml = ovfstring; Line 47: } catch (Exception e) { Line 48: throw new Exception("Failed to load the underling XML", e); maybe make this less weird Line 49: } Line 50: } Line 51: Line 52: public XmlNode SelectSingleNode(String string) { -- To view, visit http://gerrit.ovirt.org/26087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc25b6544a698df013fc6d6b2677d798408289a6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
