Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: allow automation for cluster
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/26355/1/src/plugins/ovirt-hosted-engine-setup/core/answerfile.py
File src/plugins/ovirt-hosted-engine-setup/core/answerfile.py:

Line 97:             ohostedcons.CoreEnv.ANSWER_FILE
Line 98:         ] is not None
Line 99:     )
Line 100:     def _save_answers_at_closeup(self):
Line 101:         self._save_answers()
> Perhaps notify the user that it's rewritten?
Done
Line 102: 
Line 103: 


http://gerrit.ovirt.org/#/c/26355/1/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py:

Line 455
Line 456
Line 457
Line 458
Line 459
> {cluster:}
Thanks!


-- 
To view, visit http://gerrit.ovirt.org/26355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699dda9d1286b8d6f2e251a5f0ffcaa43725da21
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnata...@gmail.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Meital Bourvine <mbour...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to